Will Tebbutt
Will Tebbutt
show
i don't think we want to overload 2-arg show here, only the 3-arg plain-text method below. The reason is that we probably want `repr` to return parseable code that recreates...
There's currently an implementation of the NeuralKernelNetwork kernel [here](https://github.com/JuliaGaussianProcesses/Stheno.jl/blob/master/src/flux/neural_kernel_network.jl) in Stheno.jl. Would anyone object to me moving it here? (I'm trying to remove Stheno's explicit dependency on KernelFunctions.jl)
1. `iskroncompatible` appears to be incorrectly implemented in a couple of places. For example, I don't believe that an `ExponentialKernel` should not be marked as compatible, or have I misunderstood...
It looks like we've got a performance bug in the above. Specifically, the primal looks to be fine: ```julia julia> @benchmark kernelmatrix(SEKernel(), $(randn(100))) BenchmarkTools.Trial: memory estimate: 158.25 KiB allocs estimate:...
Once #159 is merged, we'll have a standardised set of tests in `src`. It _may_ make sense to test that these actually catch the kinds of issues that they're designed...
#159 has thrown up a couple of issues. In particular, to get the tests to pass I had to modify [this line](https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/159/files/e73b23d6913e43da41022159141a019150982844#diff-22b199c6f4ab07ab8a4c7af34d56a4e0R32) with an additional call to `collect`. Would be...
There are quite a lot of tests that check that `metric(kernel)` returns a particular metric. It's not clear to me how much value these tests have. It probably makes sense...
The parameter `r` in our `PeriodicKernel` currently governs the size of the circle onto which the inputs are mapped. Would it not be more intuitive to parametrise it in terms...
The `DotProduct` is currently implemented as a `PreMetric`. This is unreasonable since it satisfies neither of the defining properties of a `PreMetric`.
Currently multiplication between GPs works. What are the odds of renaming this functionality to prevent users from multiplying GPs and getting unexpected results?