imageproxy
imageproxy copied to clipboard
added validuntil option
I needed some kind of TTL for the URL, so it is possible to expire public URLs to an image, so passing image URLs around and requesting the image is not possible an infinite time. My simple approach was to add a validUntil Parameter to the Options
vu{date:20060102}
I added the option to the signature so it is not possible to change the validity of the URL. For my use-case it is ok if images are only valid a single day. otherwise you would have to put some thought into URL generation in your own app to always use the same date, so browser caching would be possible longer than a single day.
What do you think?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Codecov Report
Merging #222 into master will decrease coverage by
1.43%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
- Coverage 89.16% 87.73% -1.44%
==========================================
Files 6 6
Lines 674 685 +11
==========================================
Hits 601 601
- Misses 50 59 +9
- Partials 23 25 +2
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 00652fd...12f2d48. Read the comment docs.
Hi there! This sounds like a really useful addition! Any updates on this?