quickstart icon indicating copy to clipboard operation
quickstart copied to clipboard

Published 20 hours ago • verified publisher icon wildfly

Update shopping-cart quickstart with WildFlyInitialContextFactory and wildfly-config.xml

Open sudeshnas93 opened this issue 3 years ago • 7 comments

Issue: https://issues.redhat.com/browse/WFLY-16214

sudeshnas93 avatar Apr 22 '22 08:04 sudeshnas93

retest this

iweiss avatar Apr 28 '22 09:04 iweiss

@sudeshnas93 @iweiss please update local cloned main branch and rebase this, there are CI fixes and improvements that will only apply by doing that.

Feel free to ping me on chat for assistance.

emmartins avatar May 03 '22 23:05 emmartins

@emmartins should be good now

iweiss avatar May 10 '22 07:05 iweiss

all checks failed due to checkstyle errors. @sudeshnas93 can you fix it?

chengfang avatar May 17 '22 12:05 chengfang

all checks failed due to checkstyle errors. @sudeshnas93 can you fix it?

fixed it. :)

sudeshnas93 avatar May 18 '22 09:05 sudeshnas93

@chengfang @emmartins can you please review this PR? thanks.

sudeshnas93 avatar Aug 22 '22 19:08 sudeshnas93

LGTM (already approved in May)

chengfang avatar Aug 24 '22 14:08 chengfang

@emmartins Can you check again and merge if everything is ok?

chengfang avatar Jan 10 '23 16:01 chengfang