solara icon indicating copy to clipboard operation
solara copied to clipboard

Published 20 hours ago • verified publisher icon widgetti

feat: Add FileInput component

Open Jhsmit opened this issue 2 years ago • 6 comments

Jhsmit avatar Mar 23 '23 13:03 Jhsmit

Nice work, many thanks!

Looks good. Some minor comments/changes

cc @mariobuikhuizen @Ben-Epstein

I do wonder if we need to have some integration between FileInput and FileDrop. Maybe FileInput should allow also a drop action? @mariobuikhuizen do you know if this is technically possible?

I agree this would be the best. Maybe we can merge the vue.js script parts of both but this is likely beyond me.

This is probably an ipyvuetify discussion but: For my uses cases I would like to pass additional options, such as dense=True, which are currently not implemented in the extra FileInput template. I can make a PR on ipyvuetify, but how do I add these kinds of boolean flags?

Jhsmit avatar Mar 29 '23 08:03 Jhsmit

This is a nice one, a drop zone which you can also click to browse

image (from chatpdf.com)

Thats looks like to more or less already exist / be easy to do https://codepen.io/hkchen/pen/EraZXm

Jhsmit avatar Mar 30 '23 11:03 Jhsmit

Any updates about this PR? This one provides a more comprehensive file input option than Filedrop, especially the accept and disable keyword. I see you did not explicitly add disable keyword in the param list. Do you want to add it? I do believe it will supported by kwarg, since disable is a common and useful keyword, maybe you want to directly add to the signature?

lp9052 avatar Jun 19 '23 04:06 lp9052

I've taken a quick look/pass on this PR, and there are some issues

  • ipyvuetify does not pass class_, style_ and label to the vuetify component in the template: https://github.com/widgetti/ipyvuetify/blob/master/ipyvuetify/extra/file_input.vue
  • on_file triggers directly with None
  • better typing for multiple=True/False
  • integration test needed.

Hope to do another pass soon, but if someone want to pick up some items, that would be great!

maartenbreddels avatar Jun 22 '23 12:06 maartenbreddels

I've taken a quick look/pass on this PR, and there are some issues

  • ipyvuetify does not pass class_, style_ and label to the vuetify component in the template: https://github.com/widgetti/ipyvuetify/blob/master/ipyvuetify/extra/file_input.vue
  • on_file triggers directly with None
  • better typing for multiple=True/False
  • integration test needed.

Hope to do another pass soon, but if someone want to pick up some items, that would be great!

@maartenbreddels Do you have other tickets/feature you need help? If not, I can take a look at this.

lp9052 avatar Jun 23 '23 20:06 lp9052

Those would be good to work on, otherwise see https://github.com/widgetti/solara/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 Would love to see more contributions from you 😍

maartenbreddels avatar Jun 24 '23 10:06 maartenbreddels