Video-Hub-App icon indicating copy to clipboard operation
Video-Hub-App copied to clipboard

Adding compact view option also for filmstrip view

Open semla opened this issue 4 years ago • 1 comments

As per issue #684

semla avatar Oct 11 '21 21:10 semla

Thank you @semla -- the code looks great! I'll test it out to see how it looks in the GUI and will try to merge it in soon. It might be a few weeks as I'm a bit busy with house stuff still. Cheers 🙌

whyboris avatar Oct 13 '21 05:10 whyboris

Glad to hear it is looking good! Busy at the moment and it has been a while since I saw the code so I think I leave the fixes for you. Cheers

semla avatar Oct 31 '22 07:10 semla

Thank you for the quick response 🤝 I'll fix up the minor edge case -- I appreciate the addition 🙇

Maybe this weekend 🤞

whyboris avatar Nov 01 '22 16:11 whyboris

I'm hoping to have a release at the end of February 😓 -- this year has been busier than I ever anticipated.

whyboris avatar Jan 31 '23 03:01 whyboris

I have a guess why there was some need for css improvement 😅 -- in the code (template) you instruct the app to use a class called compact-margins but it isn't part of the PR 👌

I'll merge in and fix in main

Thank you again for the contribution 🙇

This will be a part of the 5th Anniversary Release today 🥳

whyboris avatar Feb 20 '23 22:02 whyboris

🙇 thank you @semla for your contribution -- I made a small fix with this commit: https://github.com/whyboris/Video-Hub-App/commit/09c57b8fdf4a577d258376bf17dc64953cda5581

Looks beautiful ❤️

whyboris avatar Feb 20 '23 22:02 whyboris