cobalt2 icon indicating copy to clipboard operation
cobalt2 copied to clipboard

[bug] vscode syntax incorrect

Open dawsbot opened this issue 8 years ago • 6 comments

The syntax highlighting in vscode is very simplistic and does not cover a large amount of the possible token colors. Specifically, there are a large amount of tokens which are colored yellow:

screen shot 2017-02-22 at 2 41 04 pm screen shot 2017-02-22 at 2 43 16 pm

I could provide versions and example code for you to paste, but I've found this incredibly simple to reproduce. From node to shell, everything is missing it's complexity with token colorization. When comparing the same code the Sublime cobalt2 theme, they are not equal.

Other color schemes tokenize properly and work on my vscode instance, so I'm inclined to pin this issue on the vscode theme and not my local config.

dawsbot avatar Feb 22 '17 22:02 dawsbot

image

Same here

Venugopal46 avatar Apr 26 '17 07:04 Venugopal46

@Venugopal46 You'll have to quit vscode if you want cobalt2. Either that or make a massive PR to this repo. I resolved to quit vscode altogether in order to stay with the color scheme 👍

dawsbot avatar Apr 26 '17 16:04 dawsbot

same problem :-( image

This PR looks very nice!

codeofsumit avatar Jul 01 '17 07:07 codeofsumit

screen shot 2017-07-30 at 11 08 13 pm Same issue on React JSX

fpigeonjr avatar Jul 31 '17 04:07 fpigeonjr

Who would review the #151 PR? Perhaps someone like @wesbos, or do you maintain only the Sublime config?

dawsbot avatar Jul 31 '17 18:07 dawsbot

PR #151 is now merged.

ghost avatar Sep 11 '17 23:09 ghost