wemake-python-styleguide icon indicating copy to clipboard operation
wemake-python-styleguide copied to clipboard

flake8-commas no longer maintained

Open sobolevn opened this issue 3 years ago • 9 comments

We need to fork flake8-commas because it is not maintained anymore.

sobolevn avatar Nov 30 '21 15:11 sobolevn

However, as said in https://github.com/PyCQA/flake8-commas#flake8-extension-to-enforce-better-comma-placement:

Note: Black, the uncompromising Python code formatter, or add-trailing-comma can do all this comma insertion automatically. We recommend you use one of those tools instead.

So from my point of view, we are keeping sort of a redundancy here. And hence, what is the motivation to do so?


See also: https://github.com/DmytroLitvinov/awesome-flake8-extensions/issues/81#issuecomment-1016167528:

cruisen avatar Jan 19 '22 07:01 cruisen

Not all people use black 🙂 For example, I don't use it. But I still want my CI to catch this.

sobolevn avatar Jan 19 '22 07:01 sobolevn

Ok, point taken.

cruisen avatar Jan 22 '22 19:01 cruisen

FWIW: I've got a fork at https://github.com/PeterJCLaw/flake8-commas/ which I believe supports Python 3.12. It's based on @karamanolev's fork (they'd done 3.11 already).

PeterJCLaw avatar Sep 17 '23 12:09 PeterJCLaw

FWIW: I've got a fork at https://github.com/PeterJCLaw/flake8-commas/ which I believe supports Python 3.12. It's based on @karamanolev's fork (they'd done 3.11 already).

I've finally gotten around to publishing this as https://pypi.org/project/flake8-commas-x/. Maintenance is likely to be sporadic as this is mostly a self-interest thing for the moment. If there's interest from the community I'm happy to accept contributions from others, though I can't make any promises regarding responsiveness.

PeterJCLaw avatar Mar 12 '24 17:03 PeterJCLaw

I've finally gotten around to publishing this as https://pypi.org/project/flake8-commas-x/. Maintenance is likely to be sporadic as this is mostly a self-interest thing for the moment. If there's interest from the community I'm happy to accept contributions from others, though I can't make any promises regarding responsiveness.

Thanks for updating and publishing it! We will switch to your flake8-commas-x as part of our 3.12 migration and we'd be happy to contribute further fixes if/when needed. Having it published on pypi is a huge plus, as long as PRs for blocking issues are merged and published reasonably quickly.

karamanolev avatar Mar 12 '24 17:03 karamanolev