caddy-gen icon indicating copy to clipboard operation
caddy-gen copied to clipboard

Missing Docker version tags

Open tonsV2 opened this issue 5 years ago • 11 comments
trafficstars

The latest commit includes breaking changes. Which caused a server of mine to become inaccessible. Since there's no image tagged with version 0.3.0 on Docker Hub I can't easily revert.

Also a tag, possible 0.4.0, for the aforementioned commit/release would be nice.

tonsV2 avatar Aug 27 '20 09:08 tonsV2

We had a 0.3.0 release on git: https://github.com/wemake-services/caddy-gen/releases/tag/0.3.0

For some reason Dockerhub ignored it.

sobolevn avatar Aug 27 '20 09:08 sobolevn

@Siemko any ideas how we can fix the CI? https://travis-ci.com/github/wemake-services/caddy-gen/builds/176069791

sobolevn avatar Aug 27 '20 09:08 sobolevn

We had a 0.3.0 release on git: https://github.com/wemake-services/caddy-gen/releases/tag/0.3.0

For some reason Dockerhub ignored it.

If the image isn't tagged by the Git commit tag it's probably due to an misconfigured, or not configured at all, build rule.

tonsV2 avatar Aug 27 '20 18:08 tonsV2

Upon further investigation I see that a repository of mine is suffering from the same issue. I've written their support team.

tonsV2 avatar Aug 28 '20 04:08 tonsV2

I've haven't heard anything back from the support team. My suggestion is that a manual tagging is done. I'd do it myself if I had access to the registry.

tonsV2 avatar Sep 04 '20 16:09 tonsV2

The thing is: we don't what to release 1.5.0 while we have our CI broken. Can you please help fixing it?

sobolevn avatar Sep 04 '20 18:09 sobolevn

Do you mean release 0.4.0? Either way, I haven't used Travis before but if you point me in the right direction I can take a look

tonsV2 avatar Sep 04 '20 18:09 tonsV2

Yes, 0.4.0 🙂

Here's what's wrong: https://travis-ci.com/github/wemake-services/caddy-gen

sobolevn avatar Sep 04 '20 19:09 sobolevn

I've created the following pull request #42.

Fixing the curl command was simply done by sleeping for 1 second. However simply doing a curl request is a bit too little. So I wanted to assert the http status code as well. Because port 80 redirects to 443 it returns 308. Following that redirect results in the following.

curl: (35) error:14094438:SSL routines:ssl3_read_bytes:tlsv1 alert internal error

I'm guessing that is due to lack of configuration but I'm not sure.

tonsV2 avatar Sep 05 '20 06:09 tonsV2