getting-started
getting-started copied to clipboard
Fix: add the cross-env package to dependencies
add the cross-env package to dependencies
[√ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)
Checklist
- [√ ] Commit Messages follow the Conventional Commits pattern
- A feature commit message is prefixed "feat:"
- A bugfix commit message is prefixed "fix:"
- [ ] Tests for the changes have been added
Description
please describe the changes that you are making
for features, please describe how to use the new feature
please include a reference to an existing issue, if applicable
Does this PR introduce a breaking change?
[ ] Yes
[√ ] No
@huan Can you review it for me when you have time?
Please make sure the following requirements have been met for your PR before we can continue reviewing it:
- You have signed the CLA by clicking the
[CLA | not signed yet]button from the comments. - The PR has passed all the CI tests and turns green. (you can execute all tests locally by running
npm test)
@huan Thank you for your reply. The CLA has been completed, but the github actions test has not yet been completed.
Hi @timor-m , I think the cross-env and npm-run-all will be installed even without the direct dependencies. Please correct me if I'm wrong.
This PR includes many unrelated changes, including the version upgrade. Upgrading the version to the latest stable version is great, but the best practice would be to create a separate PR to do that.
I will close this PR for now, and you are welcome to create an new one by following the best practices.