getting-started icon indicating copy to clipboard operation
getting-started copied to clipboard

Add wechaty-puppet-puppeteer, and wechaty-puppet-padplus testing back into smoke testing

Open suntong opened this issue 5 years ago • 3 comments

Is your feature request related to a problem? Please describe.

wechaty-puppet-puppeteer, and wechaty-puppet-padplus testing were removed from smoke testing because they might fail in git action.

Describe the solution you'd like

  • Please add them back, for the environments that they still work. For example, for wechaty-puppet-padplus it is under Node 10 (i.e., when TRAVIS_NODE_VERSION=10, check here).
  • Request coming from https://github.com/wechaty/wechaty-getting-started/issues/100

[enhancement]

suntong avatar Apr 12 '20 15:04 suntong

Trying to fix for wechaty-puppet-padplus:

297Error: You need a valid WECHATY_PUPPET_PADPLUS_TOKEN to use PuppetPadplus

please add back the hidden WECHATY_PUPPET_PADPLUS_TOKEN. thanks (Just add it back and re-trigger https://travis-ci.com/github/wechaty/wechaty-getting-started/jobs/318599283 build, no need to change anything else)

Meanwhile, why wechaty-puppet-puppeteer was removed? What environments it can run?

suntong avatar Apr 12 '20 16:04 suntong

  1. I have added the PADPLUS TOKEN to the GitHub Actions. However, I believe that only the master branch can get that environment variable value.
  2. the wechaty-puppet-puppeteer was removed due to it can not pass the GitHub Actions with very strange behavior. I'll investigate it later, and please feel free to add it back if you can figure the problem out and fix it.

huan avatar Apr 12 '20 17:04 huan

Thanks, I moved it back since only the master branch can get that environment variable value.

Also, I added wechaty-puppet-puppeteer back to travis. I'll leave fixing it for GitHub Actions to you, :)

suntong avatar Apr 12 '20 19:04 suntong