webpack-dev-server
webpack-dev-server copied to clipboard
refactor: tweak style for overlay
- [ ] This is a bugfix
- [ ] This is a feature
- [x] This is a code refactor
- [ ] This is a test update
- [ ] This is a docs update
- [ ] This is a metadata update
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Tweak the styles for overlay.
Before
After
Breaking Changes
Additional Info
This is to partially resolves #3689
Right now I think the style improvement is not substantial. I'll add examples that use ts-loader as that print out some code snippet and iterate more.
Created this MR in case there is feedback.
Codecov Report
Base: 92.06% // Head: 92.06% // No change to project coverage :thumbsup:
Coverage data is based on head (
922c482) compared to base (d440baf). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #4576 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 16 16
Lines 1639 1639
Branches 617 617
=======================================
Hits 1509 1509
Misses 119 119
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I find out that react-error-overlay has extra logic to open file with error if the filename and line of code can be detected using this middleware.
Should I add this in as well or it's better that I implement it in another PR?
@malcolm-kee Let's do it in another PR, can you update tests? Thank you for the PR
@malcolm-kee you may have to update the snapshots for webpack v4 as well.
Thank you, feel free to send more PRs which will improve overlay