webpack-dev-server icon indicating copy to clipboard operation
webpack-dev-server copied to clipboard

ci: add node v18 workflow

Open snitin315 opened this issue 3 years ago • 4 comments

  • [ ] This is a bugfix
  • [ ] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [x] This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

snitin315 avatar Jun 15 '22 11:06 snitin315

Codecov Report

Base: 90.48% // Head: 92.06% // Increases project coverage by +1.58% :tada:

Coverage data is based on head (c8bf2d1) compared to base (87c08f1). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4491      +/-   ##
==========================================
+ Coverage   90.48%   92.06%   +1.58%     
==========================================
  Files          16       16              
  Lines        1639     1639              
  Branches      617      617              
==========================================
+ Hits         1483     1509      +26     
+ Misses        142      119      -23     
+ Partials       14       11       -3     
Impacted Files Coverage Δ
lib/Server.js 93.75% <0.00%> (+2.13%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 15 '22 11:06 codecov[bot]

hm, we should fix our tests @snitin315 Can you look at this?

alexander-akait avatar Jul 25 '22 09:07 alexander-akait

Yeah, something wrong with MacOS tests. I'll look into it.

snitin315 avatar Jul 25 '22 10:07 snitin315

@snitin315 Can we try to rebase and update all deps and test it again? Thank you

alexander-akait avatar Sep 19 '22 15:09 alexander-akait

hm, looks like some tests are broken, I will look

alexander-akait avatar Sep 25 '22 14:09 alexander-akait

closing in favor of #4599

snitin315 avatar Oct 08 '22 03:10 snitin315