webpack-dev-server icon indicating copy to clipboard operation
webpack-dev-server copied to clipboard

fix: show warning for non-web targets

Open snitin315 opened this issue 4 years ago • 2 comments
trafficstars

  • [x] This is a bugfix
  • [ ] This is a feature
  • [x] This is a code refactor
  • [x] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fixes https://github.com/webpack/webpack-dev-server/pull/2104

Breaking Changes

None

Additional Info

None

snitin315 avatar Mar 19 '21 11:03 snitin315

Codecov Report

Merging #3094 (71a9eb9) into master (257e2eb) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
+ Coverage   95.69%   95.71%   +0.01%     
==========================================
  Files          34       34              
  Lines        1279     1284       +5     
  Branches      368      370       +2     
==========================================
+ Hits         1224     1229       +5     
  Misses         51       51              
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 96.03% <100.00%> (ø)
lib/utils/DevServerPlugin.js 98.91% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 257e2eb...71a9eb9. Read the comment docs.

codecov[bot] avatar Mar 19 '21 11:03 codecov[bot]

need rebase

anshumanv avatar May 23 '21 10:05 anshumanv