webpack-dev-server icon indicating copy to clipboard operation
webpack-dev-server copied to clipboard

feat: support of injectHot and injectClient on specific chunks

Open paztis opened this issue 4 years ago • 7 comments

  • [ ] This is a bugfix
  • [x] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

In case of application with multiple iframes, only the top level frame has to listen socket for refresh This PR add the support of chunk target in the injectClient and injectHot options. You are able to limit the client injection only in specific chunks

Resolving of #2969

Breaking Changes

Additional Info

none

paztis avatar Feb 07 '21 11:02 paztis

Codecov Report

Merging #2998 (b06217c) into master (d3837f9) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
+ Coverage   92.30%   92.33%   +0.02%     
==========================================
  Files          37       37              
  Lines        1261     1278      +17     
  Branches      327      335       +8     
==========================================
+ Hits         1164     1180      +16     
- Misses         92       93       +1     
  Partials        5        5              
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 100.00% <100.00%> (ø)
lib/Server.js 94.44% <0.00%> (-0.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3837f9...6e0e451. Read the comment docs.

codecov[bot] avatar Feb 08 '21 07:02 codecov[bot]

Can you rebase?

rebase done

paztis avatar Feb 22 '21 21:02 paztis

Can you fix conflicts?

snitin315 avatar Feb 23 '21 13:02 snitin315

seems all my dev is to redo as webpack5 EntryPlugin management has been totally changed few days ago... same for the unit tests

paztis avatar Feb 23 '21 23:02 paztis

code updated, but all the unit test part has been removed. So there's no unit test for injectClient / injectHot

paztis avatar Feb 24 '21 00:02 paztis

rebase done

paztis avatar Feb 24 '21 07:02 paztis

any news ?

paztis avatar Mar 02 '21 09:03 paztis