val-loader icon indicating copy to clipboard operation
val-loader copied to clipboard

chore: ignore yarn.lock

Open ersachin3112 opened this issue 3 years ago • 4 comments

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [x] metadata update

Motivation / Use-Case

Ignore yarn.lock to prevent accidentally committing this file.

Breaking Changes

No

Additional Info

No

ersachin3112 avatar May 12 '22 11:05 ersachin3112

Codecov Report

Merging #96 (7b9d607) into master (7d222da) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files           2        2           
  Lines          69       69           
  Branches       19       19           
=======================================
  Hits           64       64           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d222da...7b9d607. Read the comment docs.

codecov[bot] avatar May 12 '22 11:05 codecov[bot]

No need, we don't use yarn, so no need to ignore it

alexander-akait avatar May 12 '22 12:05 alexander-akait

@alexander-akait yes, we don't use yarn but recently we committed yarn.lock file to master in this PR -

https://github.com/webpack-contrib/html-minimizer-webpack-plugin/pull/61/files

And we had to remove it in - https://github.com/webpack-contrib/html-minimizer-webpack-plugin/pull/63

So if we simply ignore it, this will not happen again.

ersachin3112 avatar May 12 '22 12:05 ersachin3112

We should better review PRs, we can't filter all unnecessary files using gitignore

alexander-akait avatar May 12 '22 12:05 alexander-akait