purifycss-webpack icon indicating copy to clipboard operation
purifycss-webpack copied to clipboard

Incompatible with style.css?hash

Open IAMtheIAM opened this issue 8 years ago • 3 comments
trafficstars

The plugin ignores css files if they have a hash attached to them.

/css/app.style.css?7ec000f0d0dbcb1dd347

If it was generated like this:

      new ExtractTextPlugin({
         filename: '/css/[name].style.css?[hash]',
      }),

I had customized the old API to accept the hash. Will you accept a PR for this new API to accept the hash? I basically did some regex to check for it and strip the hash off, so it could process the CSS file. Unless you know of a better way...

IAMtheIAM avatar Apr 05 '17 17:04 IAMtheIAM

Yeah, PR please.

bebraw avatar Apr 05 '17 18:04 bebraw

I got it done, forked and committed locally but it won't push to my fork. It just hangs on "running build...passed!" Using sourceTree... any ideas?

build_stuck

EDIT: got it, I had to delete .git/pre-push to get it to finish.

IAMtheIAM avatar Apr 05 '17 22:04 IAMtheIAM

PR submitted The CI test failed for some reason though, not sure why.

IAMtheIAM avatar Apr 05 '17 22:04 IAMtheIAM