mini-css-extract-plugin icon indicating copy to clipboard operation
mini-css-extract-plugin copied to clipboard

fix: valid generation `url()` for `auto` value of the `publicPath` op…

Open alexander-akait opened this issue 4 years ago • 2 comments

…tion

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [x] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

try to fix #848

Breaking Changes

No

Additional Info

Because auto allows to do relative paths in url(), we just do not allow new URL(...) to change URL using #, note - you should avoid writing stuff ./foo/../foo/image.png, because it will be not simplified and will be keeping as it

alexander-akait avatar Oct 09 '21 17:10 alexander-akait

Codecov Report

Merging #852 (3bdd6ac) into master (be7269d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #852   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files           6        6           
  Lines         776      776           
  Branches      199      199           
=======================================
  Hits          712      712           
  Misses         58       58           
  Partials        6        6           
Impacted Files Coverage Δ
src/utils.js 68.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be7269d...3bdd6ac. Read the comment docs.

codecov[bot] avatar Oct 09 '21 17:10 codecov[bot]

hm, not safe for windows...

alexander-akait avatar Oct 09 '21 17:10 alexander-akait