mini-css-extract-plugin icon indicating copy to clipboard operation
mini-css-extract-plugin copied to clipboard

fix: module.resource is not available for css files #534

Open xiaoxiaojx opened this issue 5 years ago • 9 comments

Motivation / Use-Case

https://github.com/webpack-contrib/mini-css-extract-plugin/issues/534

Breaking Changes

no

Additional Info

xiaoxiaojx avatar Jun 25 '20 11:06 xiaoxiaojx

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Jun 25 '20 11:06 jsf-clabot

Codecov Report

Merging #545 (8f109c6) into master (70ce174) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   88.77%   88.88%   +0.11%     
==========================================
  Files          11       11              
  Lines         686      693       +7     
  Branches      190      191       +1     
==========================================
+ Hits          609      616       +7     
  Misses         74       74              
  Partials        3        3              
Impacted Files Coverage Δ
src/CssModule.js 56.57% <100.00%> (+0.57%) :arrow_up:
src/index.js 91.76% <0.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70ce174...8f109c6. Read the comment docs.

codecov[bot] avatar Jun 25 '20 11:06 codecov[bot]

You need tests for this

alexander-akait avatar Jan 05 '21 16:01 alexander-akait

You need tests for this

@alexander-akait :)

xiaoxiaojx avatar Jan 28 '21 03:01 xiaoxiaojx

CI still broken

alexander-akait avatar Jan 28 '21 10:01 alexander-akait

CI still broken

npm ERR! errno 1 npm ERR! [email protected] test:coverage: npm run test:only -- --collectCoverageFrom="src/**/*.js" --coverage "--ci" npm ERR! Exit status 1 npm ERR!

It looks like the test:coverage command, and there is no problem running it locally, and there is no change in the snapshot update, so I am out of ideas :)

xiaoxiaojx avatar Jan 28 '21 16:01 xiaoxiaojx

Do you read answer https://github.com/webpack-contrib/mini-css-extract-plugin/issues/534#issuecomment-754942734?

alexander-akait avatar Jan 28 '21 16:01 alexander-akait

Well, non-essential, thanks for the reply

xiaoxiaojx avatar Jan 30 '21 15:01 xiaoxiaojx

It works in some cases, yep, but in general not in all cases

alexander-akait avatar Jan 30 '21 15:01 alexander-akait