graphql-php
graphql-php copied to clipboard
webonyx
Convert PHPEnumType constructor to use config
With all the activity around enums lately, I thought I'd trot out this old classic from May of last year (I somehow botched the old PR, so this is a do-over). The basic idea is to make the PhpEnumType constructor take a config like all the other ones.
As previously established, this is indeed a breaking change.
Kindly review, thank you.
In that case, I might consider merging this when making a future release that includes breaking changes. I don't plan on it soon though. And if the plan is to move towards named arguments then, I will most likely not make an intermediary release for this just to fix the inconsistency.
I'm cool with waiting for the next major release (it's not currently too tough to work around this issue), but that was the agreement we had the last time I opened a PR to fix this, and it didn't get merged into 15. I'm also agreeable to supporting both formats (param list and single config object) in the interim via runtime checking, but I don't want to bother doing the work if you're just going to pooh-pooh it on some kind of philosophical grounds. Let me know what you think, thanks.
I did not make a breaking release since you opened https://github.com/webonyx/graphql-php/pull/1375.
