json icon indicating copy to clipboard operation
json copied to clipboard

justinrainbow/json-schema version 3/4

Open thewilkybarkid opened this issue 9 years ago • 4 comments

Following the advice in https://github.com/justinrainbow/json-schema/issues/301 I've tried to update the library to v3's way of resolving references.

I've had to remove two tests as I don't think there's a way (as it stands) to make them pass. An upstream change to throw an exception would work, but it doesn't look to be a trivial change.

thewilkybarkid avatar Sep 05 '16 07:09 thewilkybarkid

This now supports versions 2, 3 and 4, though it's getting quite messy internally.

thewilkybarkid avatar Nov 17 '16 16:11 thewilkybarkid

@webmozart, can we get this merged? I just ran into an incompatibility issue and this would help me greatly.

yp28 avatar Dec 05 '16 09:12 yp28

Ping @webmozart.

I now have a schema that v2 appears to fail on, but I can't update due to this library (which is a dependency of Puli, I'm not actually using it myself).

thewilkybarkid avatar Jan 30 '17 08:01 thewilkybarkid

What is the latest here, is there something outstanding? @webmozart the unit tests are all passing

gsdevme avatar Jun 07 '18 00:06 gsdevme