Simon Warta

Results 381 comments of Simon Warta

I'm not planning to continue working on this. But feel free to use my commits if you want to finalize it.

If I get a 👍 for such a change, I'm happy to create a PR.

As briefly mentioned in #173, we still pull in both md5 and ripemd160 as well as helper dependencies through [pbkdf2](https://www.npmjs.com/package/pbkdf2) because this package supports those non-SHA2 algorithms. Ideally we had...

Here are noble crypro benchmarks from my machine. The 3rd block with 2048 iterations is what matters to this use case. So as long as we are happy with those...

> what is the benefit of working with the parent class, rather than a substitutable child class? Having `Buffer`s in JS code compiled for the browser is an issue in...

In order to really address this problem, we probably want to implement the Reader/Writer ourselves instead of using it from `protobufjs/minimal`. We don't want to embed them in every file,...

I'm not a fan of chaning objects to classes. Coming here from protobuf.js this was one of the best choices we saw here. In theory classes are objects anyways, but...

> Not an apology to classes, but for example `lodash#isEqual` should work fine with classes as well as plain objects. We could also have `ts-proto` generate equality check functions ,...

Taking one step back, I wonder if this is really something that needs to be implemented here and create code and drawbacks for all other users. The proto `message` objects...

This does not explain the different data, but there is a Buffer vs. Uint8Array issue in the underlying encoder (https://github.com/stephenh/ts-proto/issues/425). Can you add more info? Like the code you call...