Simon Warta
Simon Warta
The flattening is explicitely implemented here: ```go // Flatten returns a flattened version of StringEvents by grouping all attributes // per unique event type. func (se StringEvents) Flatten() StringEvents {...
Yes, so the text document written to the `log` string has a structure that does not match the `events` field and loses important structure. This makes the use of that...
> Do you have a concrete proposal? Yes, so the `log` string is a structured JSON document anyways. At the very top it looks like this: ```json [ { "events":...
Thank you for fixing this!
I'd be happy to get some reviews from Cosmos folks for - [Add CAIP-5](https://github.com/ChainAgnostic/CAIPs/pull/9/commits/512c23193ff31d366e46082d495163bd61103918) - [Add CAIP-6](https://github.com/ChainAgnostic/CAIPs/pull/9/commits/e667c5d93abb0fc0c600c72393d9441face3fc3f) in https://github.com/ChainAgnostic/CAIPs/pull/9
Having dedicated tests would be ideal indeed. In the meantime I tried generating the recover IDs but did not find an implementationation that is flexible enough which I can run...
> I would assume that the 65-byte vrs format is quite common [...] valid range for v. The `v` variable is Ethereum specific and combines a network ID and a...
That's great stuff, thanks a lot for the effort! For my purpose the split r, s, revovery_id would be ideal. IMO the protocol specifics can be done by the user...
Turns out the static global `FRAME_INFO` is increasing every time a module is deseralized from file (through `register_frame_info` aka. `fn register` in `lib/compiler/src/engine/trap/frame_info.rs`). The following debug logs ```diff diff --git...
Do you have some initial thoughts if and how this can be fixed? Do you think we need to adapt out codebase to use 1 engine per Module to work...