Simon Warta

Results 376 comments of Simon Warta

Could you commit your local changed and create a draft PR with what you have? Maybe that helps understanding what you are doing and how to best collaborate. I worked...

Thank you @vincentysc. I looked at your diff last week. That's very helpful. However, I don't think we want to integrate chain-specific functionality at that level. Sign Mode Direct is...

Hey Michael, which Tendermint version are you connecting to? Assuming Tendermint does not mix up things, the error message makes sense. Personally I'd say [8274, 8273] is an empty interval...

`revisionHeight` is of type Long, not string. That feeld needs to look something like `{ revisionHeight: Long.fromNumber(123), revisionNumber: Long.fromNumber(456) },`.

Removing from milestone to not block release on it

Thank you @assafmo! The granter was added to StdFee in https://github.com/cosmos/cosmjs/pull/1262 which is shipped with 0.29.0. The PR also contains a feegrant test. But without Amino support.

The `InProcessOnlineSigner` from #403 shows a cool way to wrap an `OfflineSigner` in an `OnlineSigner` implementation. This should be used when `OnlineSigner` is implemented.

We use the following functions from the Tendermint34Client / Tendermint RPC: - [x] status for chain ID: https://github.com/cosmos/cosmos-sdk/blob/release/v0.45.x/proto/cosmos/base/tendermint/v1beta1/query.proto#L17-L19 - [x] status for height: https://github.com/cosmos/cosmos-sdk/blob/release/v0.45.x/proto/cosmos/base/tendermint/v1beta1/query.proto#L24-L27 (maybe a bit overhead but we...

@marbar3778 can you help with any item from the list above to make progress here?