webdriverio icon indicating copy to clipboard operation
webdriverio copied to clipboard

added qmate service

Open DIFSRIP opened this issue 3 years ago • 3 comments

Proposed changes

Added the qmate-service https://sap.github.io/wdio-qmate-service/ to the supported services and docs.

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation update

Checklist

Not applicable

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

DIFSRIP avatar Sep 05 '22 07:09 DIFSRIP

CLA Not Signed

@DIFSRIP mind signing the CLA? Thanks!

christian-bromann avatar Sep 05 '22 14:09 christian-bromann

ping @DIFSRIP

christian-bromann avatar Sep 20 '22 10:09 christian-bromann

@DIFSRIP also would you mind to raise the same PR for the v7 branch?

christian-bromann avatar Sep 23 '22 05:09 christian-bromann

@DIFSRIP I went ahead and pushed the change myself. Please make sure you or your company has signed the CLI.

christian-bromann avatar Oct 05 '22 15:10 christian-bromann

@DIFSRIP I went ahead and pushed the change myself. Please make sure you or your company has signed the CLI.

So sorry for the late reply. I was on vacation for some weeks and just came back. My user is now signed to the CLI. Thanks for taking over. Anything left, I need to do from SAP side?

DIFSRIP avatar Oct 10 '22 11:10 DIFSRIP

Anything left, I need to do from SAP side?

Nope, all good!

christian-bromann avatar Oct 10 '22 16:10 christian-bromann