selenium-standalone icon indicating copy to clipboard operation
selenium-standalone copied to clipboard

Published 20 hours ago • verified publisher icon webdriverio

Rewrite project into TypeScript

Open christian-bromann opened this issue 4 years ago • 9 comments

We made the experience that switching to TypeScript had a good impact on the code quality and development velocity. We should also rewrite this project into TypeScript to leverage from the same.

christian-bromann avatar Oct 19 '21 21:10 christian-bromann

I would like to work on this.

VedanthB avatar Oct 20 '21 10:10 VedanthB

Awesome, thanks for stepping in. I would suggest to tackle this in small pieces, e.g. rather raising many small PRs than one huge one.

christian-bromann avatar Oct 20 '21 11:10 christian-bromann

Okay should i start with installing typescript in the project and then write the files in typescript one by one ?

VedanthB avatar Oct 20 '21 18:10 VedanthB

@VedanthB sounds like a good approach, maybe have a first PR that provides the TS setup and already have the package point to the compiled JS files. Then a PR for every file.

christian-bromann avatar Oct 21 '21 08:10 christian-bromann

I'll submit the PR in a day 😄

VedanthB avatar Oct 21 '21 17:10 VedanthB

Can i get help to get this running on my local machine ?

VedanthB avatar Oct 21 '21 18:10 VedanthB

Can i get help to get this running on my local machine ?

Sure, where do you struggle with? Did you check out the Contributing guidelines. It isn't much but it helped me to get it setup locally.

christian-bromann avatar Oct 21 '21 18:10 christian-bromann

i have cloned the project and npm install , what would be the next steps?

VedanthB avatar Oct 21 '21 20:10 VedanthB

what would be the next steps?

You should be able to run all tests via npm test now. The next step is setup TypeScript.

christian-bromann avatar Oct 21 '21 21:10 christian-bromann