webdataset icon indicating copy to clipboard operation
webdataset copied to clipboard

Published 20 hours ago • verified publisher icon webdataset

gopen_curl fails on windows

Open pratikgujjar opened this issue 2 years ago • 1 comments

Loading a tarfile with a url as a webdataset fails because of a wrongly formatted curl command for Windows.

CMD is: https://github.com/webdataset/webdataset/blob/main/webdataset/gopen.py#L195 Single quotes around the url lead to improper interpretation of urls that contain the & symbol on a windows machine.

pratikgujjar avatar Dec 16 '22 01:12 pratikgujjar

WebDataset generally isn't tested on Windows; I'm not sure whether we can even set up tests on GitHub for that.

If you submit a PR for gopen.py conditionalized on Windows, I can pull it in, however. All you need to do is provide the correct command strings for Windows.

tmbdev avatar Dec 20 '22 21:12 tmbdev