polyfills icon indicating copy to clipboard operation
polyfills copied to clipboard

preventing errors when scoped custom element registry is imported on the server

Open jonathandewitt-dev opened this issue 11 months ago • 3 comments

Fixes #601

This will log a warning when imported on the server, and it will effectively do nothing. Otherwise, it will carry on as the polyfill usually would for browser environments.

NOTE: make sure to enable "hide whitespace."

jonathandewitt-dev avatar Dec 20 '24 19:12 jonathandewitt-dev

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 20 '24 19:12 google-cla[bot]

I have signed the CLA, not sure why it's failing... maybe it's an issue with my git config.

image

EDIT: got it. It was indeed an issue with my git config. A little rewriting history with a new email fixed it.

jonathandewitt-dev avatar Dec 20 '24 19:12 jonathandewitt-dev

I'll add changelog updates when I get home too.

jonathandewitt-dev avatar Dec 20 '24 22:12 jonathandewitt-dev

Closing as not needed. See https://github.com/webcomponents/polyfills/issues/601 for details.

jonathandewitt-dev avatar Mar 21 '25 02:03 jonathandewitt-dev