Remove dead code

[kalwalt]

I removed most of the code that we don't need, but i think there are some files that we can delete too, I will create a list here of which files that we need to remove, but that needs to be tested.

inside include folder:

• AR folder:

  • [ ] arosg.h
  • [x] gsub.h, gsubConfig.h, gsub_es.h. gsub_es2.h, gsub_lite.h
  • [ ] video.h, videoConfig.h, VideoLuma.h, VideoRGBA.h

• ARUtil folder:

  • [x] android.h
  • [ ] thread_sub.h

• ARWrapper folder: i left this but not sure what to do with this.

• Eden folder: does we need this?

• [x] glStateCache.h and glStateCache2.h

inside lib/SRC folder:

• AR folder:

  • [ ] ref. files to Pattern Marker? what other?

• ARUtil folder: as for the include folder files tat refer to android and threading

to be completed...

[kalwalt]

We can also remove all the Makefiles, if we think that we will not build the libs with the makefile system. There is another question I ask myself: if webarkitLib will be used also by jsartoolkit5 I cannot go to remove certain files concerning Pattern, Barcode or Mult Markers, in this case I have to see how much to go deep in cleaning.

[ThorstenBux]

I think jsartoolkit5 should just stay as is.

Kind regards Thorsten Bux

Sent from my iPhone

On 14/05/2020, at 6:37 AM, Walter Perdan [email protected] wrote:



We can also remove all the Makefiles, if we think that we will not build the libs with the makefile system. There is another question I ask myself: if webarkitLib will be used also by jsartoolkit5 I cannot go to remove certain files concerning Pattern, Barcode or Mult Markers, in this case I have to see how much to go deep in cleaning.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwebarkit%2FWebARKitLib%2Fissues%2F1%23issuecomment-628171926&data=02%7C01%7C%7Cb21194b8a5c44be5d13408d7f76ca413%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637249918280473034&sdata=k2ematNAQABkHulqbLbOHq80yNLO1o8SB3IuP30UaqY%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD765PEPP4RP7LMV7323Z3LRRLSFHANCNFSM4NAAFREQ&data=02%7C01%7C%7Cb21194b8a5c44be5d13408d7f76ca413%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637249918280483034&sdata=pabmrY3YpsGPVkA9tJNm%2Fz1jn9kuhFeBxxKrnhPWRps%3D&reserved=0.

[kalwalt]

Eden has been removed with this commit https://github.com/webarkit/WebARKitLib/pull/2/commits/0ec0048cb84fc48a20701d72f49ef241a2f4f88f see also https://github.com/webarkit/WebARKitLib/pull/2#issuecomment-629223451

[subjectdenied]

wouldn't it be better to integrate (work on the build-system of the original artoolkit) webarkit/jsartoolkit/ into artoolkit and allow artoolkit to be built for "web", instead of forking in a way merging the "web" artoolkit with the "desktop" artoolkit will be amost impossible in the future?

[kalwalt]

@subjectdenied we want to develop a new lib that is based in part on the original Artoolkit5 - ArtoolkitX and oter features. Consider that actually the ARtoolkit5 repository is more than 500 mb but the code required to buld jsartoolkit5 it's around 8mb. Does make sense?