web2project icon indicating copy to clipboard operation
web2project copied to clipboard

Published 20 hours ago • verified publisher icon web2project

Add PHP extensions check to installer

Open moisseev opened this issue 10 years ago • 2 comments

resolves #289

moisseev avatar May 29 '15 06:05 moisseev

While I agree with what you've done here, I think we need to tweak the approach. The phpExtCheck method should not be embedded in the PHP here. Ideally, it would be a method on the installer class or similar. Or - failing that - it would be in the main_functions.php file to keep it with the others.

(Also, I'm sorry I didn't respond to this sooner.. I didn't get a notification that you had updated it.)

caseysoftware avatar Jul 27 '15 04:07 caseysoftware

I agree that phpExtCheck should not be embedded. But I suppose it's up to you to choose the best place for the method. If you want it on the installer class, where in the tree the Installer.class.php should be located?

moisseev avatar Aug 01 '15 08:08 moisseev