web-push-php icon indicating copy to clipboard operation
web-push-php copied to clipboard

Published 20 hours ago • verified publisher icon web-push-libs

fix: [BREAKING] remove legacy subscription; change subscription interface

Open Rotzbua opened this issue 1 year ago • 11 comments

Changes

Breaking:

  • change default encoding to aes128g
  • change subscription interface
  • Remove legacy GCM
  • Remove old Chrome subscription support

Feature:

  • convert contentEncoding to typesafe enum

Reference

fixes #381 fixes #345 reference #388

Rotzbua avatar Feb 06 '24 18:02 Rotzbua

Hey sorry I plan to review this this weekend, thanks!

Minishlink avatar Feb 14 '24 00:02 Minishlink

Hopefully this can be finished & merged soon :)

Gugu7264 avatar Jun 18 '24 09:06 Gugu7264

@Minishlink Just wondering, what's currently missing in that PR? The required fixes in reviews? (and conflicts)

Gugu7264 avatar Jun 18 '24 16:06 Gugu7264

Yes that's right

Minishlink avatar Jun 18 '24 16:06 Minishlink

I might delay this to v10 and release v9 at the beginning of july. Let me know @Rotzbua if you have time in the near future for this PR, thank you

Minishlink avatar Jun 18 '24 16:06 Minishlink

Hi, I have over 25k subscribers and need to switch to the new FCM v1 API since the old version will be deprecated soon. When will this library support the v1 API? I'm using Perfecty Push, which depends on this library.

Thanks for the amazing repo!

cclegend90 avatar Jul 16 '24 12:07 cclegend90

Hello, this library is agnostic about which endpoint is sent by the browser, it only requires compliance with the Web Push standard. Regarding FCM deprecation, Google said that it will still support the old endpoints https://stackoverflow.com/a/77958717 (but anyway this is not a question for this repository but more for Google)

Minishlink avatar Jul 16 '24 14:07 Minishlink

Converted to draft until I have time and back into the php topic.

Rotzbua avatar Jul 16 '24 14:07 Rotzbua

Thanks for the update! I have one more question: what's the pull request about? Are you planning on supporting the v1 HTTP API too, or is it focused on something else? Looking forward to your response!

cclegend90 avatar Jul 17 '24 07:07 cclegend90

@cclegend90 It is just cleanup of obsolete code. The FCM v1 HTTP API (for native apps) is not the Push API (for browser) and not target of this library.

Rotzbua avatar Jul 18 '24 13:07 Rotzbua