web-push-php icon indicating copy to clipboard operation
web-push-php copied to clipboard

web-push-php API signature change

Open sadektouati opened this issue 3 years ago • 0 comments

I lost countless hours trying to make it send the payload. I used this code Subscription::create([ 'endpoint' => $endpoint, $p256dh, $keys_auth, 'contentEncoding' => 'aesgcm', ]), Notice I used position parameters and it gives no error (except in the case of "endpoint").

Instead, it should be like this: Subscription::create([ 'endpoint' => $endpoint, 'publicKey' => $p256dh, 'authToken' => $keys_auth, 'contentEncoding' => 'aesgcm', ]),

I think it should raise an error if any of the parameters is provided without a name.

sadektouati avatar Dec 18 '21 14:12 sadektouati