pywebpush icon indicating copy to clipboard operation
pywebpush copied to clipboard

Published 20 hours ago • verified publisher icon web-push-libs

Create WebPusher send_async

Open TobeTek opened this issue 2 years ago • 3 comments

TobeTek avatar Jan 23 '23 09:01 TobeTek

I'm curious why you closed this PR. It looks really useful.

jrconlin avatar Jan 23 '23 15:01 jrconlin

Hello @jrconlin

I'm curious why you closed this PR. It looks really useful.

Opening the PR had initially been a mistake. My changes were initially intended for internal use. I implemented a send_async method for the WebPusher class.

Looking at https://github.com/web-push-libs/pywebpush/issues/150 and https://github.com/web-push-libs/pywebpush/issues/142, I assumed send_async wasn't on the roadmap.

Going ahead to reopen now, incase it proves helpful in any way.

TobeTek avatar Jan 24 '23 10:01 TobeTek

I think it might!

Heh, if there are improvements, don't be afraid to share them. Chances are good someone else might benefit as well.

Thanks!

jrconlin avatar Jan 24 '23 16:01 jrconlin