WPT has a redundant utility script to define `checkLayout`

[dholbert]

WPT has two utility scripts that define a checkLayout() utility-function: (1) check-layout-th.js, referenced in in 800+ files (note, "th" here is short for "testharness" I think): https://github.com/search?q=repo%3Aweb-platform-tests%2Fwpt%20check-layout-th.js&type=code

(2) check-layout.js, referenced in 1 file: https://github.com/search?q=repo%3Aweb-platform-tests%2Fwpt%20check-layout.js&type=code (This check-layout.js script itself is here and its one usage is here.)

It looks like the latter script (the one with only one usage) was added perhaps by accident in https://github.com/web-platform-tests/wpt/pull/31891 a few years back.

@josepharhar @bfgeek could you remove the check-layout.js file that's only used once, and update its sole usage to use the other one?

[dholbert]

(pinging you two in particular since you've got git-blame for the file itself and for the sole-usage, respectively. :) So you're likely to know if there's a reason for the file to exist, though I suspect there isn't.)

[josepharhar]

I'm on it, thanks for finding this! And sorry for accidentally adding the duplicate, I can clearly see that I didn't even use it in the patch I added.

[josepharhar]

https://chromium-review.googlesource.com/c/chromium/src/+/5947328

[josepharhar]

Looks like my patch passes all tests in chromium, it should be merged soon and then automatically upstreamed here.

[dholbert]

Thanks!