wpt icon indicating copy to clipboard operation
wpt copied to clipboard

how to handle exceptions thrown in testdriver

Open WeizhongX opened this issue 1 year ago • 3 comments

There are some exceptions thrown in testdriver-extra.js [1]. As the exceptions are thrown inside the browser, will they cause test to fail

[1] https://source.chromium.org/search?q=f:third_party%2Fwpt_tools%2Fwpt%2Ftools%2Fwptrunner%2Fwptrunner%2Ftestdriver-extra.js%20%22throw%20new%22&ss=chromium%2Fchromium%2Fsrc

WeizhongX avatar Jun 04 '24 22:06 WeizhongX

Background: this is brought up when we discuss a crashtest(html/semantics/popovers/popover-dialog-crash.html) that uses testdriver.js. The crashtest is show as passed on wpt.fyi.

WeizhongX avatar Jun 04 '24 22:06 WeizhongX

@foolip @jgraham

WeizhongX avatar Jun 04 '24 22:06 WeizhongX

Maybe the exception is ignored only when run crashtests, but as we do not care about success or failure for crash tests, this is not a problem?

WeizhongX avatar Aug 12 '24 22:08 WeizhongX

@mfreed7 What is your opinion for my question in the above comment?

WeizhongX avatar Sep 05 '24 20:09 WeizhongX

Note that crashtests currently aren't allowed to use testdriver and it won't work on the shared infra (unlike in Google's CI).

jgraham avatar Sep 06 '24 15:09 jgraham

Note that crashtests currently aren't allowed to use testdriver and it won't work on the shared infra (unlike in Google's CI).

This is true. But I think we should eventually make testdriver work with both reftests and crashtests.

WeizhongX avatar Sep 06 '24 16:09 WeizhongX