wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Published 20 hours ago • verified publisher icon web-platform-tests

Update accname/name/comp_labelledby.html with aria-labeledby [sic] tests

Open rahimabdi opened this issue 1 year ago • 3 comments

WPT investigation for this issue:

  • https://github.com/w3c/aria/issues/2093

rahimabdi avatar Dec 16 '23 00:12 rahimabdi

@cookiecrook Got it, I'll hold onto this for the time being pending WG discussion and consensus.

rahimabdi avatar Jan 06 '24 02:01 rahimabdi

I wonder, in what ways does it matter if some browsers alias the "incorrect" spelling?

It's probably okay that there's a test that points this specific use case out, mostly because it's a quirk (comparatively).

JMO, though. I don't think I want spec to openly support both, but rather just know what a browser will do in either case, for this specific use case.

MelSumner avatar Feb 06 '24 02:02 MelSumner

@MelSumner FWIW, I agree. Fortunately, all browsers appear to prefer aria-labelledby (regardless of whether it precedes aria-labeledby or not in terms of attribute order).

rahimabdi avatar Apr 07 '24 20:04 rahimabdi

I believe this PR should land given the changes were approved by the ARIA WG: https://github.com/w3c/aria/pull/2371

spectranaut avatar Jan 29 '25 18:01 spectranaut

@spectranaut wrote:

I believe this PR should land given the changes were approved by the ARIA WG: https://github.com/w3c/aria/pull/2371

Agreed. My objection above was to a test expectation that has since been removed from the PR.

cookiecrook avatar Jan 29 '25 19:01 cookiecrook

This appears to have changed the Interop 2024 results. I am not seeing a corresponding test change proposal in https://github.com/web-platform-tests/interop/issues?q=is%3Aissue%20label%3Atest-change-proposal%20 so I think the change should either be reverted, or the new tests added to another file, until Interop 2024 is complete.

jgraham avatar Jan 30 '25 16:01 jgraham

Apologies. I thought Interop 2024 was done. For those of us more on the outside of the Interop admin process, when does it end?

cookiecrook avatar Jan 30 '25 17:01 cookiecrook

No worries :) It's a bit confusing and we should invest more in automation to help people avoid making unintentional changes.

The current plan is to freeze the dashboard on or before next Thursday 6th.

jgraham avatar Jan 30 '25 18:01 jgraham

PR is up at

  • https://github.com/web-platform-tests/wpt/pull/50392

@jgraham Once the passing CI results are in, please r+ and merge at will.

cookiecrook avatar Jan 30 '25 19:01 cookiecrook

I've merged in the partial revert, and plan to re-revert that sometime next month.

  • https://github.com/web-platform-tests/interop-accessibility/issues/170

cookiecrook avatar Jan 30 '25 22:01 cookiecrook

Thanks, it's much appreciated :)

jgraham avatar Jan 31 '25 08:01 jgraham