wpt-pr-bot
wpt-pr-bot copied to clipboard
web-platform-tests
Notify people of export PRs that bypass review
In https://github.com/web-platform-tests/wpt/pull/15306 @marcoscaceres asked about being notified of changes to payment-request/. Currently, @wpt-pr-bot will approve export PRs: https://github.com/web-platform-tests/wpt-pr-bot/blob/7b89f1ab726df1ac340880d3e00c179b06c49205/lib/comment.js#L24-L27
Review on the PR itself wouldn't be meaningful, and sometimes PRs are created for changes that never land even in the upstream repository, so if people are notified doing so after the PR has been merged is probably best.
Notifying in a comment would be OK because no other humans are looking at these PRs. But it has to be simple to filter out these notifications.
@annevk I think you've asked about this as well, do you remember where the previous discussion happened?
This can really help with planning - as it allows us (i.e., Mozilla's DOM Team) to start thinking about how to fix stuff and get things prioritized when updated tests fail. It also helps catch little things, like things that are .tentative. (but not marked as such) slipping through. Even if those things get auto-merged, we are potentially able to respond more quickly.
@foolip the discussion previously might just have been on IRC; I certainly would like to know everything touching infra at least.
@foolip https://github.com/web-platform-tests/wpt/issues/8434 is somewhat related.
(If the distinction could be made, I'd be interested in seeing changes to existing tests, but not so much in the addition of new tests or tentative tests. That's where I've mainly seen errors introduced at least, which is what I care about the most.)
If the distinction could be made, I'd be interested in seeing changes to existing tests, but not so much in the addition of new tests or tentative tests.
This is technically straightforward to detect, but to notify or not depending on it would require per-user settings. I guess those could live in the META.yml files, is that what you'd like?