wpt-pr-bot icon indicating copy to clipboard operation
wpt-pr-bot copied to clipboard

Ask for review from people being added/removed in META.yml

Open zcorpan opened this issue 7 years ago • 4 comments

and omit the "There are no reviewers for this pull request." comment.

zcorpan avatar Jun 18 '18 12:06 zcorpan

To answer your security related question, we can’t have folks who aren’t yet reviewers review the PR that would make them a reviewer. That’s too easy to game.

tobie avatar Jun 18 '18 13:06 tobie

OK, that makes sense. I agree we shouldn't make people reviewers automatically, only request review. The bot could ask one of the admins to update the reviewers team if necessary?

zcorpan avatar Jun 18 '18 13:06 zcorpan

Often the people being added won't yet be org members so you won't be able to request their review.

foolip avatar Jun 18 '18 21:06 foolip

Yes, good point. The bot can detect that and mention them plus an admin

zcorpan avatar Jun 18 '18 21:06 zcorpan