Wait with asking for review until other checks have finished

[zcorpan]

wpt-pr-bot will ask for review immediately when a PR is opened.

Reviewers have more information when the other checks are complete:

• is the linter happy
• what are the PR results on wpt.fyi

My thinking is that the workflow for reviewers would be slightly smoother if the bot only asked for review when the checks have finished (successfully or not). It shouldn't delay the time to merge since the checks need to be green before merge anyway.

A possible problem is that some checks could get stuck and never finish, e.g. due to network errors. wpt-pr-bot could maybe have some kind of timeout and ask for review anyway after a few hours.

[foolip]

This is a good idea, and https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#webhook-events could probably be used to implement it.

It would be interesting to see if the token is read-only or read-write for that event :)

[foolip]

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#status-event-status would also be needed if this is done before Taskcluster migrates to GitHub Checks: https://github.com/web-platform-tests/wpt.fyi/issues/1240

[gsnedders]

I think one risk is new contributors not necessarily getting feedback so quickly, especially if they don't know how/why CI is failing?

[zcorpan]

@gsnedders

asked for review when the checks have finished (successfully or not)

i.e. also ask for review when CI is failing.