rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

URLManifestItem.url shouldn't contain non-URL-unit characters

Open gsnedders opened this issue 1 year ago • 3 comments

Rendered

gsnedders avatar Feb 16 '24 16:02 gsnedders

(There's also the variant of this RFC where all we do is url.replace(" ", "%20") which avoids the "space separated URLs" problem. But it still carries the same risks.)

gsnedders avatar Feb 16 '24 16:02 gsnedders

One question here is whether we should disallow test file paths that contain spaces, or whether we should just escape these in the URL.

Given how few such files there are, let's just disallow them.

foolip avatar Feb 17 '24 01:02 foolip

I don't think banning spaces in test names is worthwhile.

I just searched for spaces in filenames and found two cases that don't seem intentional:

https://github.com/web-platform-tests/wpt/pull/46253 https://github.com/web-platform-tests/wpt/pull/46254

Is there much of a downside to banning spaces?

foolip avatar May 14 '24 14:05 foolip