rspress
rspress copied to clipboard
feat: using view transitions API on appearance toggle
Summary
先把功能调通了,然后补一下文档,单测我不确定是否要加!
Related Issue
#1270
Checklist
- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Deploy Preview for aquamarine-blini-95325f ready!
| Name | Link |
|---|---|
| Latest commit | cbc22d8b46d895ef392636aed174cb26fa7c4250 |
| Latest deploy log | https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66d6eae017bc7c000813553b |
| Deploy Preview | https://deploy-preview-1272--aquamarine-blini-95325f.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 95 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 92 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
@SoonIter cc
this feature is conflicted with https://github.com/web-infra-dev/rspress/pull/101
two view-transition name is conflicted, 'flip' and 'root'
https://github.com/ayangweb/rspress/blob/5cfab69d674485933db69b09667576f416e96a58/packages/theme-default/src/layout/DocLayout/index.module.scss
when switching the dark mode, .rspress-doc with flip 's behavior is strange
https://github.com/user-attachments/assets/79312332-6743-42d8-8347-37dd82454133
Currently, I tried to solve the conflict but it does not work...
also need some help
@SoonIter 我想排查一下原因,可惜在我执行 pnpm dev 的时候,它经常报错!
@SoonIter 我想排查一下原因,可惜在我执行
pnpm dev的时候,它经常报错!![]()
你试着把 shared 包 和 这个包开两个终端 分别运行 dev
I solved it by some ugly codes
https://github.com/ayangweb/rspress/blob/cdc406d8532d13df53a7d851b4d1fec743061b4b/packages/theme-default/src/components/SwitchAppearance/index.tsx#L20
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ SoonIter✅ Timeless0911❌ ayangwebYou have signed the CLA already but the status is still pending? Let us recheck it.
@ayangweb Hi, can you sign the CLA to let CI pass~
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ SoonIter✅ Timeless0911❌ ayangwebYou have signed the CLA already but the status is still pending? Let us recheck it.
@ayangweb Hi, can you sign the CLA to let CI pass~
Okay, I've signed it.
