rspress icon indicating copy to clipboard operation
rspress copied to clipboard

feat: using view transitions API on appearance toggle

Open ayangweb opened this issue 1 year ago • 4 comments

Summary

先把功能调通了,然后补一下文档,单测我不确定是否要加!

Related Issue

#1270

Checklist

  • [ ] Tests updated (or not required).
  • [ ] Documentation updated (or not required).

ayangweb avatar Jul 19 '24 06:07 ayangweb

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 19 '24 06:07 CLAassistant

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
Latest commit cbc22d8b46d895ef392636aed174cb26fa7c4250
Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66d6eae017bc7c000813553b
Deploy Preview https://deploy-preview-1272--aquamarine-blini-95325f.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 95 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 19 '24 06:07 netlify[bot]

@SoonIter cc

chenjiahan avatar Jul 25 '24 14:07 chenjiahan

this feature is conflicted with https://github.com/web-infra-dev/rspress/pull/101

two view-transition name is conflicted, 'flip' and 'root'

https://github.com/ayangweb/rspress/blob/5cfab69d674485933db69b09667576f416e96a58/packages/theme-default/src/layout/DocLayout/index.module.scss

when switching the dark mode, .rspress-doc with flip 's behavior is strange

https://github.com/user-attachments/assets/79312332-6743-42d8-8347-37dd82454133

Currently, I tried to solve the conflict but it does not work...

also need some help

SoonIter avatar Jul 26 '24 11:07 SoonIter

@SoonIter 我想排查一下原因,可惜在我执行 pnpm dev 的时候,它经常报错!

image

ayangweb avatar Sep 01 '24 15:09 ayangweb

@SoonIter 我想排查一下原因,可惜在我执行 pnpm dev 的时候,它经常报错!

image

你试着把 shared 包 和 这个包开两个终端 分别运行 dev

Timeless0911 avatar Sep 02 '24 03:09 Timeless0911

I solved it by some ugly codes

https://github.com/ayangweb/rspress/blob/cdc406d8532d13df53a7d851b4d1fec743061b4b/packages/theme-default/src/components/SwitchAppearance/index.tsx#L20

SoonIter avatar Sep 03 '24 09:09 SoonIter

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ SoonIter✅ Timeless0911❌ ayangwebYou have signed the CLA already but the status is still pending? Let us recheck it.

@ayangweb Hi, can you sign the CLA to let CI pass~

Timeless0911 avatar Sep 03 '24 10:09 Timeless0911

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ SoonIter✅ Timeless0911❌ ayangwebYou have signed the CLA already but the status is still pending? Let us recheck it.

@ayangweb Hi, can you sign the CLA to let CI pass~

Okay, I've signed it.

ayangweb avatar Sep 03 '24 11:09 ayangweb