webauthn-framework icon indicating copy to clipboard operation
webauthn-framework copied to clipboard

Published 20 hours ago • verified publisher icon web-auth

Lower infection's min value

Open szepeviktor opened this issue 2 years ago • 2 comments

No one writes tests 😢

  • [ ] It is a Bug fix
  • [ ] It is a New feature
  • [ ] Breaks BC
  • [ ] Includes Deprecations

szepeviktor avatar Oct 07 '23 19:10 szepeviktor

The minimum required MSI percentage should be 42%, but actual is
41.28%. Improve your tests!

szepeviktor avatar Oct 07 '23 19:10 szepeviktor

Many thanks for trying to fix the tests. Actually, the last versions are full of deprecated features that make this minimum value less relevant. The version 4.8 will be the last 4.x version and 5. 0 will get rid of all deprecations. To sum up: do not try to fix it, it will be more relevant in next major release.

Spomky avatar Oct 07 '23 20:10 Spomky

Closing as fixed since the release of 5.0.0. Because all deprecated portions of code are gone, this test is now green.

Spomky avatar Jul 20 '24 05:07 Spomky