webauthn-framework icon indicating copy to clipboard operation
webauthn-framework copied to clipboard

Missing return declaration

Open schniko opened this issue 3 years ago • 1 comments

Hi,

unfortunately, I'm not able to make a pull request, but I found this little fix: In webauthn-symfony-bundle/src/Routing/Loader.php the function public function load($resource, string $type = null) should be declared as public function load($resource, string $type = null): mixed

The line throws a deprecation error in Symfony 6 (which this bundle is for).

Thanks in advance Nicolai

schniko avatar Jun 29 '22 11:06 schniko

Hi @schniko,

You are right. I will change that in the next release. Many thanks

Spomky avatar Aug 12 '22 16:08 Spomky

Hi,

This will be addressed in the version 4.1.0 to be released soon (see https://github.com/web-auth/webauthn-framework/blob/4.1.x/src/symfony/src/Routing/Loader.php).

Regards.

Spomky avatar Aug 29 '22 17:08 Spomky

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Sep 09 '23 00:09 github-actions[bot]