weaviate-python-client icon indicating copy to clipboard operation
weaviate-python-client copied to clipboard

Published 20 hours ago • verified publisher icon weaviate

fix: auto capitalize target collection in by_ref_multi_target

Open melsonic opened this issue 11 months ago • 5 comments
trafficstars

/fixes weaviate/weaviate#6549

melsonic avatar Dec 10 '24 18:12 melsonic

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Dec 11 '24 10:12 weaviate-git-bot

Please review @tsmith023

melsonic avatar Dec 11 '24 16:12 melsonic

Hi @melsonic, this looks great to me from an implementation PoV. Would you be willing to add an integration test that validates this fix works as intended? We have many in the integration/ directory so feel free to add it there using the testing framework we have setup! Cheers 😁

tsmith023 avatar Dec 11 '24 16:12 tsmith023

Hi @melsonic, this looks great to me from an implementation PoV. Would you be willing to add an integration test that validates this fix works as intended? We have many in the integration/ directory so feel free to add it there using the testing framework we have setup! Cheers 😁

Yeah sure, I will add the required tests in the next commit.

melsonic avatar Dec 11 '24 18:12 melsonic

Hi @tsmith023, Please review this PR when you have time. Thank you!!

melsonic avatar Dec 14 '24 09:12 melsonic