weaviate-python-client icon indicating copy to clipboard operation
weaviate-python-client copied to clipboard

Replace `threading.Lock` with `asyncio.Lock` when batching to avoid deadlocks

Open tsmith023 opened this issue 1 year ago • 2 comments

tsmith023 avatar Aug 29 '24 10:08 tsmith023

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (a373ee6) to head (252d86f). Report is 218 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/batch/base.py 88.88% 3 Missing :warning:
weaviate/collections/classes/batch.py 82.35% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   93.98%   90.08%   -3.91%     
==========================================
  Files         221      175      -46     
  Lines       21332    15081    -6251     
==========================================
- Hits        20048    13585    -6463     
- Misses       1284     1496     +212     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 29 '24 17:08 codecov-commenter

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Aug 30 '24 10:08 weaviate-git-bot

Closing in favour of https://github.com/weaviate/weaviate-python-client/pull/1371

tsmith023 avatar Oct 30 '24 12:10 tsmith023