weaviate-io icon indicating copy to clipboard operation
weaviate-io copied to clipboard

Propose moving to node v20.12.2 in docs due to errors when testing

Open nathanwilk7 opened this issue 1 year ago • 2 comments

What's being changed:

Propose moving to suggesting node v20.12.2 because of a package error when running on v19.9.0 just now (on an arm64 macbook).

Also removes node from nvm install node 19.9.0 because nvm was ignoring the version when I ran this.

Type of change:

  • [x] README

How Has This Been Tested?

  • [ ] Github action – automated build completed without errors
  • [x] Local build - the site works as expected when running yarn start

Ran yarn build locally

nathanwilk7 avatar Apr 29 '24 22:04 nathanwilk7

@databyjp I think @nathanwilk7 is running into the same thing I did when I set up locally. Our tool chain is aging and we're starting to hit compatibility problems. Let's talk to @sebawita about updating. I think you two have a better idea about what's involved.

daveatweaviate avatar Apr 30 '24 15:04 daveatweaviate

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Jul 03 '24 09:07 weaviate-git-bot

Ugh, sorry this slipped through the cracks. Noticed this while creating the PR #2764 - I will close this as a duplicate. Sorry about that @nathanwilk7 😓 that's my bad.

FWIW the GH action shows as node 20, and I've been running 20 locally without additional issues. So hopefully everything is up to date.

databyjp avatar Nov 07 '24 14:11 databyjp