ignite icon indicating copy to clipboard operation
ignite copied to clipboard

Published 20 hours ago • verified publisher icon weaveworks

Missing validation functions

Open twelho opened this issue 6 years ago • 5 comments

All missing validation functions are tracked here. If you find some validation missing, add it to this list or comment on this issue.

  • [ ] VM CPUs
  • [ ] VM memory
  • [ ] VM disk max/min sizes
  • [ ] VM port mappings

twelho avatar Aug 08 '19 16:08 twelho

Adding that network mode CNI and VM portmappings are mutually exclusive.

luxas avatar Aug 09 '19 08:08 luxas

CNI now supports port mappings, so removing the mutual exclusitivity requirement.

twelho avatar Aug 30 '19 21:08 twelho

Hello, I am a student from the University of Texas at Austin. I wanted to know if a group of my colleagues and I could work on this issue as part of an assignment for our virtualization class. Thank you!

(We don't have experience with virtualization so we chose an issue with the label good first issue)

anirudh-goyal avatar Sep 20 '20 11:09 anirudh-goyal

Hi @anirudh-goyal, we would welcome your contributions

This is definitely an approachable issue. It's related to the api's we use to describe VM's

The code that needs to change starts here: https://github.com/weaveworks/ignite/blob/9c9c4db/pkg/apis/ignite/validation/validation.go#L21-L22

Also, feel free to join our development calls on Monday.

stealthybox avatar Sep 28 '20 15:09 stealthybox

Hi! Is this issue still open to be worked on? My partner and I are students from UT Austin, and we were wondering if we could tackle this as a good first issue for our virtualization class?

jeffreyxie0615 avatar Feb 17 '23 05:02 jeffreyxie0615