integrant-repl icon indicating copy to clipboard operation
integrant-repl copied to clipboard

Published 20 hours ago • verified publisher icon weavejester

Add ClojureScript support

Open clyfe opened this issue 4 years ago • 5 comments

Issue #15

clyfe avatar Dec 06 '20 15:12 clyfe

Can you remove the Add deps.edn commit? A PR should contain commits relating to a single change.

weavejester avatar Dec 06 '20 17:12 weavejester

Merging this would be awesome!

kidpollo avatar Jan 20 '21 23:01 kidpollo

Merging this would be awesome!

I also have a use case that needs Clojurescript support. Lo and behold this PR is already here. Thanks for the work @clyfe!

twashing avatar Jan 27 '21 18:01 twashing

@weavejester - is there anything in this PR that is holding up bringing this into the main line.

ckirkendall avatar Mar 08 '21 21:03 ckirkendall

@weavejester - is there anything in this PR that is holding up bringing this into the main line.

Mostly me finding time to test this, since it currently can't be done automatically.

Speaking of which, there doesn't appear to be any development setup for this change. I've confirmed the Clojure version works, but I'd appreciate some :dev profile setup for ClojureScript, so I can test that as well.

weavejester avatar Mar 10 '21 08:03 weavejester