Willem Deconinck
Willem Deconinck
Does #43 fix the remaining issues here?
Hi @climbfuji I have also come to realise that the FINAL feature should probably not be enabled by default anymore. Different compilers tend to behave differently and it is hard...
It looks like we need to support CMake 3.18
Hi @pmaciel great job for landing this! 💪💪💪 I will need a little bit of time to go through, and probably will review it in chunks at a time if...
Is it the intention to remove the feature CONVEX_HULL ?
OK, thanks. There's still a change in how Qhull is detected after your last commit. Probably best to leave it as it was, without "REQUIRED_PACKAGES", and use `find_package(Qhull)` further. If...
The design of Configuration was that eckit::Value is an implementation detail. see e.g. comment ```c++ class Configuration : public Parametrisation { /// @note Do NOT expose eckit::Value in the interface...
@tlmquintino , @simondsmart could you please advise on the desired API as discussed above?
> @tlmquintino , @simondsmart could you please advise on the desired API as discussed above? ping @tlmquintino @simondsmart
I think 4 months should be **more** than enough for a PR waiting for review. Unless someone objects before Friday 24/05/2024, I will assume everything is OK.