Worms David
Worms David
> I'd need some help to make the tests work as I'm not familiar at all with mocha The error is related to mocha not calling the Node.js `--loader` argument...
> ``` > Error: Use CoffeeScript.register() or require the coffeescript/register module to require .coffee files. > ``` Replace all occurrences of `../lib/index.js` with `../dist/esm/index.js` in the tests and they will...
I am reluctant to introduce dependencies, but there is `arr.flat(Infinity)` now which shall do the job.
I am trying to refresh my mind but I am pretty sure you are right, `require` and `plugin` look like transitional properties. `hook.plugin` is the associated plugin name, and `hook.require`...
> we should not dynamically add properties to the Hook interface Then you can always declare those properties. If I remember correctly, the idea is that user-provided hooks don't need...
> Is the call_sync function still in use Yes, I use it in some libraries
> It added semicolons, single-quotes... Is it OK like this ? That's fine. My preference is no semicolons for personal projects, not settled for open source projects (csv packages are...
Hi @LucasDemea, could you please do a review of my commit 41cdf637cfc36c477a109722ac9848d0b9da2a05 I am not too happy of my TS skills, here are a few notes: - `./lib/index.ts` line 92:...
@LucasDemea I don't see any new comment. To me, the last comment is "I will have a look. Not sure I'll find the time this week though". Am I missing...
Please propose a definition file. There is still a lot of work pending to complete this PR and no time to do it.