yalc icon indicating copy to clipboard operation
yalc copied to clipboard

no-sig parameter doesn't works

Open MateuszJonak opened this issue 4 years ago • 2 comments

I found an issue that --no-sig parameter doesn't work and it's probably because the signature boolean in this method https://github.com/wclr/yalc/blob/214ab0371aedd2212e2b21a9b9481cbdaf742404/src/copy.ts#L127 is overloaded in this line: https://github.com/wclr/yalc/blob/214ab0371aedd2212e2b21a9b9481cbdaf742404/src/copy.ts#L185.

MateuszJonak avatar Aug 18 '21 14:08 MateuszJonak

Seems I forgot to update the readme https://github.com/wclr/yalc/blob/master/CHANGELOG.md#100pre51-2021-04-23

wclr avatar Aug 20 '21 22:08 wclr

I just ran into this also. This readme part is no longer accurate:

While copying package content, yalc calculates the hash signature of all files and, by default, adds this signature to the package manifest version. You can disable this by using the --no-sig option.

It's now the opposite: by default the hash is not calculated or added to version, unless you use the --sig option.

matthias-ccri avatar Apr 11 '23 22:04 matthias-ccri